Wireshark-commits: [Wireshark-commits] master adc46f5: Tighten the NO_MORE_DATA_CHECK macros
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 29 Mar 2014 16:04:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=adc46f571c0357f7600c5cc49c21a8e1403a2af0
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

adc46f5 by Evan Huus (eapache@xxxxxxxxx):

    Tighten the NO_MORE_DATA_CHECK macros
    
    We should return if we've already somehow overflowed the apparent length, not
    just if we've hit it dead on.
    
    Fixes bug #9932 and probably others.
    
    Change-Id: I2719c3bd38f03e18ea557df962ee4a1beb64c2e8
    Reviewed-on: https://code.wireshark.org/review/862
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  302632f   Fix some compiler issues on windows with Lua 5.2
    adds  adc46f5   Tighten the NO_MORE_DATA_CHECK macros


Summary of changes:
 epan/dissectors/packet-ansi_a.c       |    2 +-
 epan/dissectors/packet-gsm_a_common.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)