Wireshark-commits: [Wireshark-commits] master f7c6254: tvb_get_ascii_string is really expensive. On
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 28 Mar 2014 14:05:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7c62543f97260654b28381e7a082dcefa56bf68
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f7c6254 by AndersBroman (anders.broman@xxxxxxxxxxxx):

    tvb_get_ascii_string is really expensive. On a large capture file which I
    profiled in october Fetch cost has gone from 15,6M to 24,2M, changing
    tvb_get_string() to tvb_get_string_enc() with ENC_UTF_8 where it seems
    safe helps a bit and should be done any way.
    
    Change-Id: I4d3e640bfde3304a991c09e2a30ad7dd132fc5ac
    Reviewed-on: https://code.wireshark.org/review/855
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3438243   Fix crash when calling "MAP Summary" dialog when no file is open
    adds  f7c6254   tvb_get_ascii_string is really expensive. On a large capture file which I profiled in october Fetch cost has gone from 15,6M to 24,2M, changing tvb_get_string() to tvb_get_string_enc() with ENC_UTF_8 where it seems safe helps a bit and should be done any way.


Summary of changes:
 epan/dissectors/packet-sdp.c |   64 +++++++++++++++++++++---------------------
 epan/dissectors/packet-sip.c |   34 +++++++++++-----------
 2 files changed, 49 insertions(+), 49 deletions(-)