Wireshark-commits: [Wireshark-commits] master 1f28f47: Fix Bug 9915 'GIOP dissector prints non-UTF-
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Mar 2014 14:48:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f28f472c85f51cc7925f18bca285ccfe0d4e5f6
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1f28f47 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix Bug 9915 'GIOP dissector prints non-UTF-8 to Info column'
    
    When the capture file in Bug 9915 is opened in wireshark with GTK2,
    the console prints out 'Pango-WARNING **: Invalid UTF-8' warnings.
    This capture file was a subset of the one in fuzzbot crash bug 9883.
    I believe it is what's causing the crash in 9883, because GTK is
    finicky about such things. But my system doesn't crash for bug 9883,
    so perhaps it's not the same root cause.
    
    Change-Id: Ifaaed9157f9abd34014001c954647f7db51d650b
    Reviewed-on: https://code.wireshark.org/review/786
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  4acdfe3   Fix request for implicit conversion from 'gpointer' to 'struct file_priv_t *' not permitted in C++
    adds  1f28f47   Fix Bug 9915 'GIOP dissector prints non-UTF-8 to Info column'


Summary of changes:
 epan/dissectors/packet-giop.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)