Wireshark-commits: [Wireshark-commits] master 97ba940: fix a crash in the GTK "Interface Management
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Mar 2014 21:24:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97ba9406e73646c1653189a5980559abc8b207fa
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

97ba940 by Martin Kaiser (wireshark@xxxxxxxxx):

    fix a crash in the GTK "Interface Management" dialogue
    for Pipes and Local Interfaces
    (Capture / Options / Manage Interfaces)
    
    if you start with an empty dialogue, select a pipe using Browse and
    press Save, wireshark crashes because of a strcmp() against the
    uninitialized pipe_name
    
    initialize pipe_name to NULL and make sure its value is reset when the
    dialogue is closed
    
    don't add a pipe unless there's an active selection in the pipe list
    (which may be "New Pipe")
    
    Change-Id: Id460c8d0d43cd7fc4cb8f4e9b4357898bbef20f7
    Reviewed-on: https://code.wireshark.org/review/776
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  752e545   Fix API comments and don't use sprintf in wslua_int64.c
    adds  97ba940   fix a crash in the GTK "Interface Management" dialogue for Pipes and Local Interfaces (Capture / Options / Manage Interfaces)


Summary of changes:
 ui/gtk/capture_dlg.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)