Wireshark-commits: [Wireshark-commits] master 9f6f6bc: Reorganize the code.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Mar 2014 07:22:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f6f6bc14e76b49a73cc2dd7333dfdb76d28616a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9f6f6bc by Guy Harris (guy@xxxxxxxxxxxx):

    Reorganize the code.
    
    Pull the packet data copying code into the routines that parse the rest
    of the record data.  Have those routines directly fill in the metadata
    headers in the packet data, without bothering to fill in a structure
    first.
    
    As a result, those routines no longer can set phdr->caplen to a value
    different from phdr->len, so don't set WTAP_HAS_CAP_LEN.
    
    Have the existing sanity checking code cause the read to fail if the
    checks fail, and add some additional sanity checking.
    
    Use #defines for some offsets into the statistics header and trailer.
    
    Change-Id: Ie936683b96888961d6e2598131cc0eb6146b37e9
    Reviewed-on: https://code.wireshark.org/review/689
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4342323   Support to version 3.0 of netscaler packet wire format.
    adds  9f6f6bc   Reorganize the code.


Summary of changes:
 wiretap/vwr.c |  823 +++++++++++++++++++++++++++++++--------------------------
 1 file changed, 448 insertions(+), 375 deletions(-)