Wireshark-commits: [Wireshark-commits] master 813bc10: Fix -Wabsolute-value in GTK Compare stat (Fo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Mar 2014 11:41:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=813bc10e8fdf5df2dc876b6e1da90d9e1de70802
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

813bc10 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Fix -Wabsolute-value in GTK Compare stat (Found by Clang 3.5)
    
    compare_stat.c:235:34: error: taking the absolute value of unsigned type 'guint32' (aka 'unsigned int') has no effect [-Werror,-Wabsolute-value]
    compare_stat.c:235:34: note: remove the call to 'abs' since unsigned values cannot be negative
    compare_stat.c:406:55: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
    compare_stat.c:406:55: note: remove the call to 'abs' since unsigned values cannot be negative
    compare_stat.c:432:56: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
    compare_stat.c:432:56: note: remove the call to 'abs' since unsigned values cannot be negative
    
    Change-Id: I03cc3136df3faf42c25986f52f015b8d87ce5774
    Reviewed-on: https://code.wireshark.org/review/675
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  35648de   Fix -Wabsolute-value in GTK SCTP Graph (Found by Clang 3.5)
    adds  813bc10   Fix -Wabsolute-value in GTK Compare stat (Found by Clang 3.5)


Summary of changes:
 ui/gtk/compare_stat.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)