Wireshark-commits: [Wireshark-commits] master 0d2dd00: Fix -Wabsolute-value in ICMP dissector (foun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Mar 2014 11:38:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0d2dd005647d173959fdd1794ff04840eb5e8cd4
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0d2dd00 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Fix -Wabsolute-value in ICMP dissector (found by Clang 3.5)
    
    packet-icmp.c:1245:7: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
    packet-icmp.c:1245:7: note: remove the call to 'abs' since unsigned values cannot be negative
    packet-icmp.c:1245:30: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
    packet-icmp.c:1245:30: note: remove the call to 'abs' since unsigned values cannot be negative
    packet-icmp.c:1254:6: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
    packet-icmp.c:1254:6: note: remove the call to 'abs' since unsigned values cannot be negative
    packet-icmp.c:1254:29: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
    packet-icmp.c:1254:29: note: remove the call to 'abs' since unsigned values cannot be negative
    packet-icmp.c:1623:7: error: taking the absolute value of unsigned type 'guint32' (aka 'unsigned int') has no effect [-Werror,-Wabsolute-value]
    packet-icmp.c:1623:7: note: remove the call to 'abs' since unsigned values cannot be negative
    packet-icmp.c:1629:7: error: taking the absolute value of unsigned type 'guint32' (aka 'unsigned int') has no effect [-Werror,-Wabsolute-value]
    packet-icmp.c:1629:7: note: remove the call to 'abs' since unsigned values cannot be negative
    
    Change-Id: I6b344d01b8239fb93aedf95d954ef1243ba45a6b
    Reviewed-on: https://code.wireshark.org/review/673
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3094062   Use constants instead of vwr->STATS_LEN in some cases.
    adds  0d2dd00   Fix -Wabsolute-value in ICMP dissector (found by Clang 3.5)


Summary of changes:
 epan/dissectors/packet-icmp.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)