Wireshark-commits: [Wireshark-commits] master 3158a5b: Use vwr->STATS_LEN instead of numbers, and e
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Mar 2014 01:37:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3158a5b22e91f406c6ced070e73cc6efeb125485
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3158a5b by Guy Harris (guy@xxxxxxxxxxxx):

    Use vwr->STATS_LEN instead of numbers, and eliminate redundant checks.
    
    Instead of throwing in 48 and 64 as numbers, use vwr->STATS_LEN to
    indicate what the lengths are.  Yeah, it has to be fetched at run time,
    but big deal.
    
    That also shows that, as we've already rejected records whose size is
    less than vwr->STATS_LEN, we don't have to check for that, so eliminate
    those checks.
    
    Change-Id: Id4822b3e5a02abfffb2da96a50999e36548a4279
    Reviewed-on: https://code.wireshark.org/review/663
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ba7e5e3   len and caplen are derived independently, so set WTAP_HAS_CAP_LEN.
    adds  3158a5b   Use vwr->STATS_LEN instead of numbers, and eliminate redundant checks.


Summary of changes:
 wiretap/vwr.c |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)