Wireshark-commits: [Wireshark-commits] master c8b6b76: Thou shalt not put newlines in the strings i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Mar 2014 22:10:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8b6b7699635cd5f9039d6a90d2267ac06e205c5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c8b6b76 by Guy Harris (guy@xxxxxxxxxxxx):

    Thou shalt not put newlines in the strings in value_string tables.
    
    That just breaks too many things.
    
    This catches the examples of that found in bug 9878.  There might be
    others that my grepping didn't find.
    
    We should also have the checkAPIs.pl script check for this, so this
    isn't a full fix for bug 9878.
    
    Change-Id: I3bf6f1fc0fe8654d0f54a995e72f1966ae012f5e
    Reviewed-on: https://code.wireshark.org/review/623
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  0284e87   Consistently put -lm at the end of library lists.
    adds  c8b6b76   Thou shalt not put newlines in the strings in value_string tables.


Summary of changes:
 asn1/lcsap/packet-lcsap-template.c |    6 ++----
 epan/dissectors/packet-lcsap.c     |   14 ++++++--------
 plugins/gryphon/packet-gryphon.c   |    2 +-
 3 files changed, 9 insertions(+), 13 deletions(-)