Wireshark-commits: [Wireshark-commits] master 00be1d3: Migrate GTK icon handling to GTK 3.10 API
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Mar 2014 05:38:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=00be1d31ce580a6ad7ac37cb04d2dea9f20fa130
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

00be1d3 by Balint Reczey (balint@xxxxxxxxxxxxxxx):

    Migrate GTK icon handling to GTK 3.10 API
    
    GtkStockItem usage is deprecated with all the GTK_STOCK_.* stock ids.
    We keep a stock id based approach but without relying on GTK's
    GtkStockItem system.
    
    We create our own internal stock ids for {icon, label} tuples and keep
    the original GTK stock id #define-s and values to preserve backward
    compatibility.
    
    Change-Id: Ia0b35a5903f079e92c8026e3df21bbf0be2d06b0
    Reviewed-on: https://code.wireshark.org/review/302
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  234ab5b   Replace (int)sizeof(guint*) by value guint8 => 1 guint16 => 2 guint32 => 4 guint64 => 8
    adds  00be1d3   Migrate GTK icon handling to GTK 3.10 API


Summary of changes:
 ui/gtk/about_dlg.c                |    1 +
 ui/gtk/airpcap_dlg.c              |   10 +-
 ui/gtk/capture_dlg.c              |   20 +-
 ui/gtk/capture_file_dlg.c         |    4 +-
 ui/gtk/capture_if_dlg.c           |    2 +-
 ui/gtk/color_dlg.c                |   20 +-
 ui/gtk/color_edit_dlg.c           |    2 +-
 ui/gtk/compare_stat.c             |    2 +-
 ui/gtk/dcerpc_stat.c              |    2 +-
 ui/gtk/decode_as_dlg.c            |    3 +-
 ui/gtk/dlg_utils.c                |   12 +-
 ui/gtk/export_pdu_dlg.c           |    2 +-
 ui/gtk/file_import_dlg.c          |    2 +-
 ui/gtk/filter_dlg.c               |    6 +-
 ui/gtk/find_dlg.c                 |    2 +-
 ui/gtk/flow_graph.c               |    4 +-
 ui/gtk/follow_stream.c            |    6 +-
 ui/gtk/graph_analysis.c           |    5 +-
 ui/gtk/iax2_analysis.c            |    7 +-
 ui/gtk/io_stat.c                  |    2 +-
 ui/gtk/main_filter_toolbar.c      |   10 +-
 ui/gtk/main_menubar.c             |    2 +-
 ui/gtk/main_statusbar.c           |    3 +-
 ui/gtk/main_toolbar.c             |    4 +-
 ui/gtk/main_welcome.c             |    2 +-
 ui/gtk/mcast_stream.c             |    1 +
 ui/gtk/mcast_stream_dlg.c         |    7 +-
 ui/gtk/packet_win.c               |    9 +
 ui/gtk/prefs_capture.c            |    4 +-
 ui/gtk/prefs_column.c             |    5 +-
 ui/gtk/prefs_dlg.c                |    4 +-
 ui/gtk/prefs_filter_expressions.c |    5 +-
 ui/gtk/print_dlg.c                |    2 +-
 ui/gtk/profile_dlg.c              |    7 +-
 ui/gtk/rpc_stat.c                 |    2 +-
 ui/gtk/rtp_analysis.c             |    8 +-
 ui/gtk/rtp_player.c               |   10 +-
 ui/gtk/rtp_stream_dlg.c           |   12 +-
 ui/gtk/sctp_assoc_analyse.c       |    7 +-
 ui/gtk/sctp_byte_graph_dlg.c      |    3 +-
 ui/gtk/sctp_chunk_stat_dlg.c      |    5 +-
 ui/gtk/sctp_error_dlg.c           |    3 +-
 ui/gtk/sctp_graph_dlg.c           |    3 +-
 ui/gtk/sctp_stat_dlg.c            |    3 +-
 ui/gtk/simple_dialog.c            |   10 +-
 ui/gtk/stock_icons.c              |  575 ++++++++++++++++++++++++++-----------
 ui/gtk/stock_icons.h              |  565 ++++++++++++++++++++++++++++++++++++
 ui/gtk/tap_param_dlg.c            |    2 +-
 ui/gtk/uat_gui.c                  |   16 +-
 ui/gtk/voip_calls_dlg.c           |   10 +-
 50 files changed, 1124 insertions(+), 289 deletions(-)