Wireshark · Wireshark-commits: [Wireshark-commits] master 9961ee3: Fix Bug 9870 'Lua: trying to call/get an invalid name results in

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9961ee369c97768d5ed906d5ef5d17b718d33d3e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9961ee3 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix Bug 9870 'Lua: trying to call/get an invalid name results in a get-loop error'
    
    Due to the change I made previously for how methods are accessed, if you try
    to access one that doesn't exist (for example mistype it or whatever), you get
    an internal Lua error about a loop in table get, as opposed to the right error
    message about the field not existing.
    
    That's because I had set the class' metatable __index metamethod to point to
    the class table, which of course has the metatable with the __index
    metamethod, causing a lookup loop.  Blech.
    
    Change-Id: I20d3717feadd45f652c2640e1671846184e7082d
    Reviewed-on: https://code.wireshark.org/review/593
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f4de2a2   packet-scsi.c minor changes - add WWN dissection and fix a typo Change-Id: I0ef84e088988f1a40863ab54b722faace8bacc31 Reviewed-on: https://code.wireshark.org/review/592 Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    adds  9961ee3   Fix Bug 9870 'Lua: trying to call/get an invalid name results in a get-loop error'


Summary of changes:
 epan/wslua/wslua.h           |    6 ++--
 epan/wslua/wslua_internals.c |   77 ++++++++++++++++++++++++++++++++++++++----
 test/lua/inspect.lua         |   11 +++++-
 test/lua/verify_globals.lua  |    9 +++--
 4 files changed, 90 insertions(+), 13 deletions(-)