Wireshark-commits: [Wireshark-commits] master-1.8 14a9251: Fix Bug 9853: 'Lua: trying to get/access
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 9 Mar 2014 16:22:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14a9251fa39cae829666b853d56577d51f97fa7e
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.8
Repository: wireshark

Commits:

14a9251 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix Bug 9853: 'Lua: trying to get/access a Preference before its registered causes a segfault'
    
    Accessing a pref before it's registered causes a segfault, because prefs_p->next
    is not being checked for NULL in wslua_proto.c:Prefs__index().
    
    Change-Id: I270978ddb9238a9e8d2c533a96fc01ee0df385c7
    Reviewed-on: https://code.wireshark.org/review/563
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/573
    

Actions performed:

    from  49ec9a2   [Automatic manuf, services and enterprise-numbers update for 2014-03-09]
    adds  14a9251   Fix Bug 9853: 'Lua: trying to get/access a Preference before its registered causes a segfault'


Summary of changes:
 epan/wslua/wslua_proto.c |   23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)