Wireshark-commits: [Wireshark-commits] master 1b2559d: Fix DNP3 Dissector DNP3 Read Requests and Di
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 7 Mar 2014 07:01:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b2559de3e19244a94a93ddb5a4c0ee219b1ab12
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1b2559d by cbontje (cbontje@xxxxxxxxx):

    Fix DNP3 Dissector DNP3 Read Requests and Direct Op No ACKs
    
    This corrects a couple issues with the DNP3 Dissector:
    - Refactored Read Object String lookups to use value_string
    - Corrected issue with multiple object types in a single read not being processed
    - Added processing for Direct Operate No ACK Messages
    
    Fixes issues noted in Bug 9839
    
    Change-Id: I9895e509a8d3931c805ce53b718a4951f8f8039e
    Reviewed-on: https://code.wireshark.org/review/538
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  419ee94   packet-smb2: setup decryption keys for kerberos session setups
    adds  1b2559d   Fix DNP3 Dissector DNP3 Read Requests and Direct Op No ACKs


Summary of changes:
 epan/dissectors/packet-dnp.c |   88 +++++++++++++++++++++++-------------------
 1 file changed, 49 insertions(+), 39 deletions(-)