Wireshark-commits: [Wireshark-commits] master e2ed48a: Have NFLOG TLV type and length be in host by
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 6 Mar 2014 05:53:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2ed48a8d38e7a885d47ba213e7deb72e18ca3d9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e2ed48a by Guy Harris (guy@xxxxxxxxxxxx):

    Have NFLOG TLV type and length be in host byte order.
    
    When capturing, they'll be in host byte order.  The top of the libpcap
    trunk and 1.5 branch, when reading a file, will, if necessary, byte-swap
    the type and length values so that they're in the byte order of the host
    reading the file (rather than the host that wrote the file).
    
    Do the same when we read a file, and have the NFLOG dissector assume
    host byte order for those fields.
    
    Change-Id: I493aed1e07b626af1157d75f3bc293b0a694ad07
    Reviewed-on: https://code.wireshark.org/review/148
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  dc7d5f9   Add a few grouped AVP definitions for 3GPP-Slh
    adds  e2ed48a   Have NFLOG TLV type and length be in host byte order.


Summary of changes:
 epan/dissectors/packet-nflog.c |   83 +++-------------------------------------
 epan/tvbuff.h                  |   17 ++++++++
 wiretap/pcap-common.c          |   80 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 102 insertions(+), 78 deletions(-)