Wireshark-commits: [Wireshark-commits] master 83b9949: Show ymsg.content as bytes; it's not a simpl
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83b994909b7e0b0a95c1b1bb9e080e5e98c2bb70
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
83b9949 by Guy Harris (guy@xxxxxxxxxxxx):
Show ymsg.content as bytes; it's not a simple string.
The content of a YMSG message is a sequence of lines, each one of which
contains a text string (in some ASCII-based encoding) for a key, a
0xc080 separator, and a text string (in some ASCII-based encoding) for a
value. That's not a string in any ASCII-based encoding I know of - 0xc0
0x80 is not, for example, a valid UTF-8 sequence (it's a too-long
sequence for NUL).
This should fix bug 9832:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9832
by avoiding the general "GTK+ on Windows crashes when asked to copy
something that's not valid UTF-8" problem.
Fix some field descriptions while we're at it.
Change-Id: I4084dabc89b0186ecd1a7329452ca2f1cb48f1c0
Reviewed-on: https://code.wireshark.org/review/488
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from f94674d truncate UTF-8 strings only at the boundary between two characters
adds 83b9949 Show ymsg.content as bytes; it's not a simple string.
Summary of changes:
epan/dissectors/packet-ymsg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)