Wireshark · Wireshark-commits: [Wireshark-commits] master 1795b40: Move value_string defs from .h file; create/use extended value_s

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1795b4021c43c3a8bfc90a4303fb9ce17f5f26bd
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1795b40 by Bill Meier (wmeier@xxxxxxxxxxx):

    Move value_string defs from .h file; create/use extended value_string; Other minor changes.
    
    - Multiple value string arrays were defined in packet-fcels.h (which was included
      in two differnt .c files). Only one of the arrays was actually used in two
      different .c files. All the value_string arrays (and most of the #defines)
      moved to packet-fcels.c.
    
    - Other:
      Use -1 instead of tvb_length() for the length param of several proto_tree_add...() calls.
      Add editor modelines.
    
    Change-Id: Idc642caf1c8d62b658147a234d5560b8f2fd0630
    Reviewed-on: https://code.wireshark.org/review/479
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Tested-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  1f2f2ba   Create/use an extended value-string; Move value-string array from .h file; Do other misc.
    adds  1795b40   Move value_string defs from .h file; create/use extended value_string; Other minor changes.


Summary of changes:
 epan/dissectors/packet-fcels.c |  346 +++++++++++++++++++++++++++++++++++++---
 epan/dissectors/packet-fcels.h |  277 +-------------------------------
 epan/dissectors/packet-fcp.c   |    4 +-
 3 files changed, 324 insertions(+), 303 deletions(-)