Wireshark-commits: [Wireshark-commits] master 9afdd44: Improve SCTP association lookup.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 2 Mar 2014 21:52:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9afdd44eec055a06291f3ccd9d12ebd2fcf4a809
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9afdd44 by Evan Huus (eapache@xxxxxxxxx):

    Improve SCTP association lookup.
    
    It's still O(n) in the worst case since the comparison function doesn't appear
    to be suitable for use in a tree or hash-table, but at least we no longer spend
    O(n) by default just finding the end of the list so we can iterate backwards.
    
    Discovered while investigating bug #9823, but probably not the cause of that
    bug.
    
    Change-Id: Ib6c3691cff8e7fa49703df7c75635ef797c8fbe8
    Reviewed-on: https://code.wireshark.org/review/443
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0f2014b   Scan-build didn't like the fixes in g79ef36a5f.
    adds  9afdd44   Improve SCTP association lookup.


Summary of changes:
 epan/dissectors/packet-sctp.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)