Wireshark-commits: [Wireshark-commits] master-1.8 217293b: Don't mix emem and glib memory and init
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Feb 2014 23:54:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=217293ba4a0353bf5d657e74fe8623dd3c86fe08
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.8
Repository: wireshark

Commits:

217293b by Evan Huus (eapache@xxxxxxxxx):

    Don't mix emem and glib memory and init routines.
    
    The seasonal memory is freed before the init routine is called, leading to a
    whole bunch of use-after-free errors.
    
    Fixes bug #9802 (and duplicates).
    
    This introduces a few minor leaks but I can't find an easy way to add additional
    free calls that doesn't lead to double-free errors.
    
    Change-Id: I1536fcb8e96f5560ad366169e815f62967b3e40d
    Reviewed-on: https://code.wireshark.org/review/407
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  fc51c55   From stcook
    adds  217293b   Don't mix emem and glib memory and init routines.


Summary of changes:
 epan/dissectors/packet-rlc.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)