Wireshark-commits: [Wireshark-commits] master-1.10 d7d1104: Bugfix OpenSafety "heuristics" to only
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Feb 2014 22:47:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d7d110415cdeb84a726c11cd47fd3269ff6144f7
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

d7d1104 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Bugfix OpenSafety "heuristics" to only consider a packet "handled" if a subdissector is called.  Fixes bug 9572 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9572)
    
    Also removed tree check in Modbus dissector because dissector_try_string() is being called under it.
    
    svn path=/trunk/; revision=54193
    cherry-picked from 6db9eb0b73b4bb02864ab389c74f5a17a9da50e2. Added
    release note entry.
    
    Change-Id: I9bad5846d08cbf8b9c40c6a17a7f88712451794e
    Reviewed-on: https://code.wireshark.org/review/344
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  5514231   Don't intentionally use -1 as an hfindex: while only naughty before, with the changes from r49644 you'll get complaints about the hf being unregistered...
    adds  d7d1104   Bugfix OpenSafety "heuristics" to only consider a packet "handled" if a subdissector is called.  Fixes bug 9572 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9572)


Summary of changes:
 docbook/release-notes.asciidoc      |    3 ++-
 epan/dissectors/packet-mbtcp.c      |    4 ----
 epan/dissectors/packet-opensafety.c |    6 ++++--
 3 files changed, 6 insertions(+), 7 deletions(-)