Wireshark-commits: [Wireshark-commits] master-1.8 31e7202: Don't intentionally use -1 as an hfindex
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Feb 2014 22:16:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31e7202fd227b1c0202408bd0c4dc382e927c168
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-1.8
Repository: wireshark

Commits:

31e7202 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't intentionally use -1 as an hfindex: while only naughty before, with the
    changes from r49644 you'll get complaints about the hf being unregistered...
    
    Note that this code also intentionally passes -1 as an ett_index.  It doesn't
    currently complain so I'm leaving it alone for now...
    
    svn path=/trunk/; revision=49648
    (cherry picked from commit 813dcf79a15d6527cce8a6a7bac4234de6ab577f with
    manual intervention)
    
    Change-Id: I38cf7946969972a9ab03a56966b10f880476f55c
    Reviewed-on: https://code.wireshark.org/review/341
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  6c858b2   NAS EPS: fix dissection of CS service notification message
    adds  31e7202   Don't intentionally use -1 as an hfindex: while only naughty before, with the changes from r49644 you'll get complaints about the hf being unregistered...


Summary of changes:
 asn1/t124/packet-t124-template.c |   27 +++++++++++++++++++++------
 epan/dissectors/packet-t124.c    |   31 +++++++++++++++++++++++--------
 2 files changed, 44 insertions(+), 14 deletions(-)