Wireshark-commits: [Wireshark-commits] master cfeae2f: Fix clang warning regarding null pointer use
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Feb 2014 16:43:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cfeae2f86c2f4b3dda9c9a73cedcbc04664c8a2a
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cfeae2f by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix clang warning regarding null pointer use in packet-sip.c.
    
    In malformed sip-sec header fields, missing spi-c/spi-s values will
    cause thie 'value' pointer to remain NULL, leading to bad things.
    This fix checks for that and adds an expert warning about malformed
    sip-sec mechanism.
    
    Change-Id: Ia7d1741fc8d829dd14e5c68f21fa99282eddbeab
    Reviewed-on: https://code.wireshark.org/review/299
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  22149c5   TVB API deprecations and cleanup
    adds  cfeae2f   Fix clang warning regarding null pointer use in packet-sip.c.


Summary of changes:
 epan/dissectors/packet-sip.c |   33 ++++++++++++++++++++++-----------
 1 file changed, 22 insertions(+), 11 deletions(-)