Wireshark-commits: [Wireshark-commits] master 696353c: Add test suite for verifying Lua global vari
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Feb 2014 16:28:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=696353c129e9db05c46f5c59436944396d8318a7
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

696353c by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Add test suite for verifying Lua global variables/tables of previous releases have not disappeared.
    
    Several bugs have been introduced due to changing of perl scripts or #define names, such
    that things exported into Lua have dissapeared or changed unintentionally. This commit
    adds a test suite which compares the Lua global table with the ones from previous
    releases (1.8 and 1.10), to verify nothing has gone missing. New items can be added, but
    old ones cannot go away. The added script to verify these things, called 'verify_globals.lua',
    also has the ability to display what's new - i.e., what was not in the olrder releases.
    
    Lastly, this commit also fixes a bug: MENU_STAT_ENDPOINT became MENU_STAT_ENDPOINT_LIST
    due to a change in the make-init-lua.pl perl script in this 1.11 release.
    
    Change-Id: Iba143d1a436e706970635a5f8cc2b317955392bf
    Reviewed-on: https://code.wireshark.org/review/284
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  fe64c46   And we need wslua_internals.obj as well.
    adds  696353c   Add test suite for verifying Lua global variables/tables of previous releases have not disappeared.


Summary of changes:
 epan/wslua/make-init-lua.pl |    2 +-
 epan/wslua/wslua_pinfo.c    |    2 +
 stat_menu.h                 |    1 +
 test/captures/empty.pcap    |  Bin 0 -> 24 bytes
 test/lua/globals_1.10.txt   |  827 +++++++++++++++++++++++++++++++++++++++++++
 test/lua/globals_1.8.txt    |  625 ++++++++++++++++++++++++++++++++
 test/lua/inspect.lua        |  706 ++++++++++++++++++++++++++++++++++++
 test/lua/verify_globals.lua |  132 +++++++
 test/suite-wslua.sh         |   23 ++
 9 files changed, 2317 insertions(+), 1 deletion(-)
 create mode 100644 test/captures/empty.pcap
 create mode 100644 test/lua/globals_1.10.txt
 create mode 100644 test/lua/globals_1.8.txt
 create mode 100644 test/lua/inspect.lua
 create mode 100644 test/lua/verify_globals.lua