Wireshark-commits: [Wireshark-commits] master 5b7f001: Add test suite for verifying Lua global vari
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Feb 2014 02:06:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b7f00178f45149ecdce204f1c71c1598ceedac1
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5b7f001 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Add test suite for verifying Lua global variables/tables of previous releases have not disappeared.
    
    Several bugs have been introduced due to changing of perl scripts or #define names, such
    that things exported into Lua have dissapeared or changed unintentionally. This commit
    adds a test suite which compares the Lua global table with the ones from previous
    releases (1.8 and 1.10), to verify nothing has gone missing. New items can be added, but
    old ones cannot go away. The added script to verify these things, called 'verify_globals.lua',
    also has the ability to display what's new - i.e., what was not in the olrder releases.
    
    Lastly, this commit also fixes a bug: MENU_STAT_ENDPOINT became MENU_STAT_ENDPOINT_LIST
    due to a change in the make-init-lua.pl perl script in this 1.11 release.
    
    Change-Id: Ic46172904256dc535b0fe4543237c07dddb3b9b5
    Reviewed-on: https://code.wireshark.org/review/242
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  9246a70   Cleanup on aisle 5: normalizes the Lua code to follow common schema/model
    adds  5b7f001   Add test suite for verifying Lua global variables/tables of previous releases have not disappeared.


Summary of changes:
 epan/wslua/make-init-lua.pl |    2 +-
 stat_menu.h                 |    1 +
 test/captures/empty.pcap    |  Bin 0 -> 24 bytes
 test/lua/globals_1.10.txt   |  827 +++++++++++++++++++++++++++++++++++++++++++
 test/lua/globals_1.8.txt    |  625 ++++++++++++++++++++++++++++++++
 test/lua/inspect.lua        |  706 ++++++++++++++++++++++++++++++++++++
 test/lua/verify_globals.lua |  121 +++++++
 test/suite-wslua.sh         |   23 ++
 8 files changed, 2304 insertions(+), 1 deletion(-)
 create mode 100644 test/captures/empty.pcap
 create mode 100644 test/lua/globals_1.10.txt
 create mode 100644 test/lua/globals_1.8.txt
 create mode 100644 test/lua/inspect.lua
 create mode 100644 test/lua/verify_globals.lua