Wireshark-commits: [Wireshark-commits] master 1995e42: Stack overflow after selecting data when fil
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Feb 2014 14:07:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1995e424df1e2364e4c0b0ca5d1e6a3b08c94bc4
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1995e42 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Stack overflow after selecting data when filter is applied that has no results (Wireshark Qt)
    
    Fix
    0x00000000004a480e in PacketList::contextMenuEvent (this=0xbbb460, event=0x7fffffffd270)
        at ui/qt/packet_list.cpp:485
    485	            if (cap_file_->edt->pi.ipproto == IP_PROTO_SCTP)
    
    Closed-bug : 9769
    
    Change-Id: I1a657d7208a10c829b2dfe90abb168eff93cd268
    Reviewed-on: https://code.wireshark.org/review/224
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  4ca528f   Add explicit casts to fix OSX10.5 Buildbot
    adds  1995e42   Stack overflow after selecting data when filter is applied that has no results (Wireshark Qt)


Summary of changes:
 ui/qt/packet_list.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)