Wireshark · Wireshark-commits: [Wireshark-commits] master d49485e: Statistics->Flow Graph in qtshark crashes with a segfault

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d49485e191b9203d1c52b7e62e06f1d768342b62
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d49485e by David Ameiss (dameiss@xxxxxxxxxx):

      Statistics->Flow Graph in qtshark crashes with a segfault
      
      What appears to be happening is SequenceDiagram::draw() is iterating over the stored seq_analysis_item_t elements - but at the same time SequenceDialog::fillDiagram() is running - which destroys the old seq_analysis_info_t (which SequenceDiagram has stored a copy of and is referencing items in the list) then reloads it.
      
      I'll attach a patch to SequenceDialog::fillDiagram() which fixes the problem - essentially calling sequence_analysis_list_get() with a new seq_analysis_info_t, calling SequenceDialog::setData() with the new one, then destroying the current seq_analysis_info_t and replacing it with the new on
      
      Change-Id: I14f7b5dc64018ba5b81fe8d874a701e021401859
      Closed-bug:9506
      Reviewed-on: https://code.wireshark.org/review/175
      Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
      Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
      

Actions performed:

      from  5e3113e   Finish converting the Developer's Guide to AsciiDoc.
      adds  d49485e   Statistics->Flow Graph in qtshark crashes with a segfault


Summary of changes:
 ui/qt/sequence_dialog.cpp |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)