Wireshark-commits: [Wireshark-commits] master 0353c9a: Fix Bug 6489 to stop compiler warning on gcr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Feb 2014 19:41:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0353c9a8e357f688cd8d9523ab10a95c7bc8473d
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0353c9a by Hadriel Kaplan (hadrielk@xxxxxxxxx):

      Fix Bug 6489 to stop compiler warning on gcrypt deprecated delcarations
      
      The libgcrypt library has several deprecated functions exported, that we don't use.
      Unfortunately the GCC compiler warns about these deprecated functions regardless,
      which is quite annoying.  This commit makes clang/gcc ignore the deprecated attribute,
      for gcrypt.h only.  The danger with this is if gcrypt ever deprecates a function
      we actually *use*, then we won't see the warning.  So I'm not sure if it's a good or
      bad idea to do this change, but it's really annoying to see the warnings and makes
      finding real warnings difficult.
      
      Change-Id: I03e80a6e7e4833ce0f709088c9ab4af98193db3d
      Reviewed-on: https://code.wireshark.org/review/128
      Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
      Tested-by: Martin Kaiser <wireshark@xxxxxxxxx>
      

Actions performed:

      from  3fd9a5e   Licensecheck improvements, just two errors left.
      adds  0353c9a   Fix Bug 6489 to stop compiler warning on gcrypt deprecated delcarations


Summary of changes:
 wsutil/wsgcrypt.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)