Wireshark-commits: [Wireshark-commits] master f555415: Fix bug 9733 ' Lua: wtap_filetypes.TSPREC_ v
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5554155a1acef955df56fc5da656a5d6496c59d
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
f555415 by Hadriel Kaplan (hadrielk@xxxxxxxxx):
Fix bug 9733 ' Lua: wtap_filetypes.TSPREC_ variable names are missing from the Lua global table'
The fix for bug 9712, which involved changing the make-init-lua.pl perl script
to handle the new C-code define names for filetypes in release 1.11,
unfortunately also stopped matching against the timestamp define names.
Arguably the timestamp ones should never have been matched to begin with, at
least not by the same regex function, because they're not "filetypes". But
they've been matched and exported into the Lua table forever, so we'll break
backward-compat if we don't keep doing it. Ugh.
The good news is I caught this bug using a new test script I wrote which
verifies previous release's Lua stuff didn't disappear. I'll submit that
separately when I get a chance to clean it up, hopefully next week.
Change-Id: Ibf1d1da0dc4ed62cc1bacf345742dccf8ec40e30
Reviewed-on: https://code.wireshark.org/review/143
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from 9a26416 Have macros to handle the range check and byte swapping.
adds f555415 Fix bug 9733 ' Lua: wtap_filetypes.TSPREC_ variable names are missing from the Lua global table'
Summary of changes:
epan/wslua/make-init-lua.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
