Wireshark-commits: [Wireshark-commits] rev 54951: /trunk/plugins/wimax/ /trunk/plugins/wimax/: msg_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: eapache@xxxxxxxxxxxxx
Date: Fri, 24 Jan 2014 20:48:55 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54951

User: eapache
Date: 2014/01/24 08:48 PM

Log:
 The wimax plugin primarily uses tvb_get_ptr buffer accesses instead of the
 safe accessor functions, and it's all done via scary bit-twiddling macros to
 boot.
 
 Create the macros TVB_NIB_WORD and TVB_NIB_NIBBLE that (should) behave just
 like the raw-pointer NIB_WORD and NIB_NIBBLE macros, except using the safe tvb
 functions instead.
 
 Replace two instances with the safe versions, which fixes an out-of-bounds
 access caught by my valgrind fuzzer. If this doesn't break anything then we
 should probably do a wholesale replacement at some point, but I'm not feeling
 that adventurous at the moment.

Directory: /trunk/plugins/wimax/
  Changes    Path            Action
  +2 -2      msg_ulmap.c     Modified
  +8 -0      wimax_bits.h    Modified