Wireshark · Wireshark-commits: [Wireshark-commits] rev 53523: /trunk/ui/gtk/ /trunk/ui/gtk/: main_menubar.c

[guy@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=53523

User: guy
Date: 2013/11/23 07:51 PM

Log:
 Always check cf->edt before dereferencing it, so that Coverity doesn't
 say "you checked it here, but you dereferenced it later even if it was
 null when you checked it".
 
 This obviates the need for some checks of frame_selected, as cf->edt
 will be non-null iff cf->current_frame is non-null.
 
 Always check *cf, not cfile, in set_menus_for_selected_packet(). 
 Currently, cf always == &cfile, but we aren't guaranteeing that will be
 true forever.

Directory: /trunk/ui/gtk/
  Changes    Path              Action
  +6 -6      main_menubar.c    Modified