Wireshark · Wireshark-commits: [Wireshark-commits] rev 52203: /trunk/plugins/wimax/ /trunk/plugins/wimax/: mac_hd_generic_decoder.c

[mmann@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52203

User: mmann
Date: 2013/09/24 06:45 PM

Log:
 Wimax dissector improvements:
 
 1. Remove message type field from all MAC Management "sub"dissectors and place it in Mac Management subdissector itself.  This may cause backwards-compatibility issues (malformed packets) with third-party subdissectors of the MAC Management dissector, but it didn't make sense to have so many filters for a single enumerated value, especially when the various "protocol" filters covers many of them.
 
 2. Removed some if(tree) checks as column info and calling other dissectors are sometimes executed underneath.  Some of this is in preparation for addressing bug 5349.
 
 3. Make all dissector functions (and a few others) static, and use register_dissector() when necessary.
 
 4. Convert generic decoder CRC errors into expert info, rather than have it be a "protocol" filter (it just looks funny that way)
 
 
 In general, these dissectors seem "over-protocolized". I understand the need for all of the dissectors, but I don't know if they all need "protocol" status.

Directory: /trunk/plugins/wimax/
  Changes    Path                        Action
  +53 -37    mac_hd_generic_decoder.c    Modified
  +55 -57    mac_mgmt_msg_decoder.c      Modified
  +25 -59    msg_aas_beam.c              Modified
  +18 -42    msg_aas_fbck.c              Modified
  +13 -62    msg_arq.c                   Modified
  +5 -25     msg_clk_cmp.c               Modified
  +5 -25     msg_dcd.c                   Modified
  +37 -52    msg_dlmap.c                 Modified
  +10 -49    msg_dreg.c                  Modified
  +20 -90    msg_dsa.c                   Modified
  +20 -87    msg_dsc.c                   Modified


(18 files not shown)