Wireshark · Wireshark-commits: [Wireshark-commits] rev 51331: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-scsi-osd.c

[etxrab@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=51331

User: etxrab
Date: 2013/08/12 10:29 PM

Log:
 From Javier Godoy:
 Dissect additional OSD-2 service actions (CREATE/REMOVE PARTITION, GET/SET ATTRIBUTES, QUERY).
 
 This patch adds support for some OSD-2 service actions, following the approach described in bug 8832.
 
 The implemented service actions are:   
  - CREATE PARTITION
  - REMOVE PARTITION
  - REMOVE COLLECTION
  - GET ATTRIBUTES
  - SET ATTRIBUTES
  - QUERY
   
 The following service action codes was #defined
  - OSD_2_REMOVE_PARTITION	0x888c
 	
 The following trees were added 
  - ett_osd2_query_criteria_entry
 
 The following fields were added:	
  - hf_scsi_osd2_remove_scope (REMOVE PARTITION)
  - hf_scsi_osd2_immed_tr (QUERY)
  - hf_scsi_osd2_matches_collection_object_id (QUERY)
  - hf_scsi_osd2_query_type (query list CDB continuation descriptor)
  - hf_scsi_osd2_query_entry_length (query list CDB continuation descriptor)
  - hf_scsi_osd2_query_attributes_page (query list CDB continuation descriptor)
  - hf_scsi_osd2_query_attribute_number (query list CDB continuation descriptor)
  - hf_scsi_osd2_query_minimum_attribute_value_length (query list CDB continuation descriptor)*
  - hf_scsi_osd2_query_maximum_attribute_value_length (query list CDB continuation descriptor)*
  * (dissection of the attribute value in query descriptors is not implemented yet)
  
 The following value_string arrays were added:
  - scsi_osd2_remove_scope_val (OSD2r4 Table 143)
  - scsi_osd2_query_type_vals (OSD2r4 Table 75)
  
 The following value_string arrays were updated:		
  - scsi_osd_svcaction_vals
  - scsi_osd2_object_descriptor_format_val
  
 The following functions were added:	 
  - dissect_osd2_query
  - dissect_osd2_query_list_descriptor (dissect CDB continuation descriptor type 0x0002)
  
 The following expert_info fields were added:
  - ei_osd2_query_values_equal (PI_PROTOCOL,PI_NOTE) - the minimum and maximum attribute values are equal in a query descriptor entry
   
 Changes in dissect_osd2_cdb_continuation:
  - Dissect case 0x0002 
  
 Changes in dissect_osd_*
  - Initialize extra_data->osd2
  - Dissect OSD-2 specific fields
  - Call dissect_osd_cdb_continuation_length / dissect_osd_cdb_continuation  (if osd2)
  - Version-specific increment of offset after dissecting capability/security_parameters
 
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9029

Directory: /trunk/epan/dissectors/
  Changes    Path                 Action
  +332 -23   packet-scsi-osd.c    Modified