Wireshark-commits: [Wireshark-commits] rev 50310: /trunk/epan/dissectors/ /trunk/epan/dissectors/:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: mmann@xxxxxxxxxxxxx
Date: Mon, 01 Jul 2013 23:59:06 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50310

User: mmann
Date: 2013/07/01 04:59 PM

Log:
 Make expert items filterable and a little cleanup.
 
 Remove NULL tree check at start of dissection to ensure expert info is populated.
 
 Overall I think the logic could be a little cleaner (length checking and its tie to expert info seems excessive), but I'm not familiar enough to be comfortable making the changes.
 
 This dissector appears to be vulnerable to DOS attacks through its unsigned 16-bit length fields (just from static inspection).  Having the length be a signed 32-bit value even if the length in the protocol field is an unsigned 16-bit value could simplify some of the logic.

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +142 -184  packet-wccp.c    Modified