Wireshark-commits: [Wireshark-commits] rev 44223: /trunk/epan/dissectors/ /trunk/epan/dissectors/:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: pascal@xxxxxxxxxxxxx
Date: Thu, 02 Aug 2012 19:34:40 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44223

User: pascal
Date: 2012/08/02 12:34 PM

Log:
 Fix a few issues:
 - restore test on ciphered and deciphered variables removed in r44035: they are used by dct2000 and fp_hint dissectors
 - rename channel information lchid to rbid: the corresponding variable is supposed to contain a Radio Bearer Identity and not a Logical Channel Identity and was already used like this in dct2000 and fp_hint dissectors or with UDP framing protocol. Please add a new variable in rlc_info structure if the lchid is really useful
 - do not display channel information when the direction is unknown (useful for UDP framing protocol for ex)
 - add channel information to UM dissection also
 As a rule of thumb, please check that the changes do not break existing dissectors: UMTS RLC dissection can be configured in packet-catapult-dct2000.c, packet-fp_hint.c, through the UDP framing protocol explained in packet-rlc.h and not only in packet-umts_fp.c and packet-umts-mac.c

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +17 -11    packet-rlc.c    Modified