Wireshark · Wireshark-commits: [Wireshark-commits] rev 42816: /trunk/ /trunk/ui/gtk/: capture_file_dlg.c /trunk/: file.c file.h /tr

[guy@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=42816

User: guy
Date: 2012/05/23 07:16 PM

Log:
 In the "Save As" and "Export Specified Packets" code path, do a "safe
 save" if the destination file exists.
 
 Don't forbid overwriting an existing file in either of those cases (we
 still forbid overwriting the current capture file) - the GUI asks the
 user whether they want to do the overwrite, and allows them to cancel
 out of it - and don't remove the file before writing to it (doing so
 makes the save *un*safe).
 
 Attempt to do a save of an unedited temporary file by just moving the
 file on Windows as well as on UN*X - ws_rename() will remove the target
 if necessary on Windows (and won't do it as a separate operation before
 attempting the rename), so it behaves like ws_rename() on UN*X (which is
 just a wrapper around rename()).

Directory: /trunk/ui/gtk/
  Changes    Path                  Action
  +13 -16    capture_file_dlg.c    Modified

Directory: /trunk/
  Changes    Path          Action
  +73 -87    file.c        Modified
  +11 -18    file.h        Modified

Directory: /trunk/ui/win32/
  Changes    Path                Action
  +30 -51    file_dlg_win32.c    Modified