Wireshark · Wireshark-commits: [Wireshark-commits] rev 41722: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-mpeg-descript

[etxrab@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=41722

User: etxrab
Date: 2012/03/21 06:07 AM

Log:
 From Guy Martin:
 Fix
 Coverity has 3 complaints about this dissector, reported in CID's 1450-1451
 CONSTANT_EXPRESSION_RESULT:
 
 Event result_independent_of_operands: (crid & 3) >> 2 is 0 regardless of the
 values of its operands [non-specific operand of assignment].
 1385             crid_type = (crid &
 MPEG_DESCR_CONTENT_IDENTIFIER_CRID_LOCATION_MASK) >> 2;
 
 
 Event result_independent_of_operands: flags & 0x1000 is always 0 regardless of
 the values of its operands (logical operand of if).
 1512             if (flags & MPEG_DESCR_LOGON_INITIALIZE_CONNECTIVITY_MASK) {
 
 
 Event result_independent_of_operands: flags & 0x1000 is always 0 regardless of
 the values of its operands (logical second operand of '&&').
 1544         if (offset < end && (flags &
 MPEG_DESCR_LOGON_INITIALIZE_CONNECTIVITY_MASK)) {
 
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6960

Directory: /trunk/epan/dissectors/
  Changes    Path                        Action
  +5 -3      packet-mpeg-descriptor.c    Modified