Wireshark-commits: [Wireshark-commits] rev 40742: /trunk/epan/dissectors/ /trunk/epan/dissectors/:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: morriss@xxxxxxxxxxxxx
Date: Fri, 27 Jan 2012 22:59:26 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40742

User: morriss
Date: 2012/01/27 02:59 PM

Log:
 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6712 :
 
 Since SMPP knows the time zone of its (absolute) times and since we don't
 have access to a mktime() routine that doesn't take into account the local
 time zone (and since I don't think repeatedly setting the TZ environment
 variable is a healthy choice):
 
 1) subtract the 'timezone' (or '_timezone' on Windows) back out after calling
    mktime()
 2) then adjust the time to take into the protocol-specified time zone
 3) and (finally) display the time in UTC (since we don't have the
    infrastructure to display it in the protocol-specified time zone).
 
 (I *think* (1) is portable: POSIX says that variable should exist...)

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +12 -4     packet-smpp.c    Modified