Wireshark · Wireshark-commits: [Wireshark-commits] rev 40033: /trunk/ /trunk/epan/dissectors/: packet-gsm_map.c /trunk/asn1/gsm_map

[etxrab@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40033

User: etxrab
Date: 2011/11/28 11:03 PM

Log:
 Wireshark crashes in gsm_map dissector
 
 For now use Jeff's fix:
 "The REAL problem is that the GSM_MAP dissector is using this value_string_ext
 in the hf without BASE_EXT_STRING:
 
     { &hf_gsm_old_localValue,
       { "localValue", "gsm_old.localValue",
         FT_INT32, BASE_DEC, &gsm_old_GSMMAPOperationLocalvalue_vals_ext, 0,
         "OperationLocalvalue", HFILL }},
 
 This, in turn, appears to be caused because OperationLocalValue is an alias
 for/of GSMMAPOperationLocalValue and only the latter is defined with
 .USE_VALS_EXT.
 
 I can fix it by doing:
 
 Index: asn1/gsm_map/gsm_map.cnf
 ===================================================================
 --- asn1/gsm_map/gsm_map.cnf    (revision 39628)
 +++ asn1/gsm_map/gsm_map.cnf    (working copy)
 @@ -54,6 +54,7 @@
 
  #.USE_VALS_EXT
  GSMMAPOperationLocalvalue
 +OperationLocalvalue
 
  #.EXPORTS
  AddressString
 
 
 But it seems to be that asn2wrs should arguably be figuring this out on its
 own."

Directory: /trunk/epan/dissectors/
  Changes    Path                Action
  +43 -43    packet-gsm_map.c    Modified

Directory: /trunk/asn1/gsm_map/
  Changes    Path           Action
  +1 -0      gsm_map.cnf    Modified