Wireshark-commits: [Wireshark-commits] rev 29480: /trunk/epan/ /trunk/epan/: proto.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: krj@xxxxxxxxxxxxx
Date: Wed, 19 Aug 2009 19:08:36 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=29480

User: krj
Date: 2009/08/19 12:08 PM

Log:
 Move TRY_TO_FAKE_THIS_ITEM to all public proto_xxx methods. Currently we rely on our internal (static) helper functions to do the faking. However, when they fake a protocol tree, they usually return a valid tree (although a dummy tree it is still a valid one). This means that we end up calling proto_tree_set_representation + friends on it for no reason. By moving TRY_TO_FAKE_THIS_ITEM to the public proto_xxx methods we're able to bail immediately (when we're allowed to do so).

Directory: /trunk/epan/
  Changes    Path          Action
  +110 -5    proto.c       Modified