Wireshark-commits: [Wireshark-commits] rev 28963: /trunk/epan/dissectors/ /trunk/epan/dissectors/:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: gerald@xxxxxxxxxxxxx
Date: Mon, 06 Jul 2009 20:23:41 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=28963

User: gerald
Date: 2009/07/06 01:23 PM

Log:
 From Kovarththanan Rajaratnam via bug 3652:
 
 This patch protects against malformed Unique ID lengths (>= 252 bytes) and
 defer all tvb_xxx related calls to when we actually need them. This allows us
 to dissects as much as possible before bailing out (in case of a malformed
 length).
 
 From me:
 
 Add a link to the protocol specification.  Remove packet-miop.h along
 with some struct definitions. (Don't tvb_memcpy over structs!) Remove
 some more tvbuffs.  Don't call proto_item_add_subtree if we're not going
 to use the trees.  Call proto_tree_add_item instead of
 proto_tree_add_text Remove a bunch of unused ett_ variables.  Add an
 expert item for the protocol version.  Register the field array with the
 correct length.

Directory: /trunk/epan/dissectors/
  Changes    Path               Action
  +0 -1      Makefile.common    Modified
  +91 -108   packet-miop.c      Modified
  +0 -55     packet-miop.h      Removed