Wireshark-commits: [Wireshark-commits] rev 26039: /trunk/epan/dissectors/ /trunk/epan/dissectors/:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=26039
User: etxrab
Date: 2008/08/19 01:05 AM
Log:
From Neil Piercy:
RR has been split from DTAP, with common stuff going to the common files (plus a few minor knock-on consequences).
Fix the broken tap:
I had not realised that the register_tap call in the dissector registration actually _created_ the tap entry (not the register_tap_listener), and not just associated the tap_id returned with the tap registered by the listener. The use of separate statics by the split lead to 3 taps called "gsm_a", but only the first of which was ever found in the tap_queue_packet. Added (yet another) global for now to cope.
Also attached is a patch to tap.c which simply returns the same tap_id if the register_tap is called twice with the same name - I can't see any downside to this, can you? Anyway it seemed to work with deliberately keeping multiple calls.
Directory: /trunk/epan/dissectors/
Changes Path Action
+1 -0 Makefile.common Modified
+1 -7 packet-bssap.c Modified
+4 -20 packet-gsm_a_bssmap.c Modified
+1226 -0 packet-gsm_a_common.c Modified
+202 -8 packet-gsm_a_common.h Modified
+354 -6436 packet-gsm_a_dtap.c Modified
+3 -6 packet-gsm_a_rp.c Modified
+4899 -0 packet-gsm_a_rr.c Added
