Wireshark · Wireshark-commits: [Wireshark-commits] rev 26035: /trunk-1.0/ /trunk-1.0/asn1/: Makefile.am /trunk-1.0/epan/crypt/: air

[gerald@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=26035

User: gerald
Date: 2008/08/18 10:58 AM

Log:
 Copy over revisions from the trunk:
 
 ------------------------------------------------------------------------
 r25531 | martinm | 2008-06-23 07:58:17 -0700 (Mon, 23 Jun 2008) | 16 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-sip.c
 
 Show short version of Content-Length header.
 Fixes but 2635.
 
 ------------------------------------------------------------------------
 r25862 | etxrab | 2008-07-29 11:02:09 -0700 (Tue, 29 Jul 2008) | 4 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-sip.c
 
 Handle malformed SIP headers (empty header line missing) and add an expert
 item explaining the fault.
 Fixes bug
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2729
 ------------------------------------------------------------------------
 r25551 | guy | 2008-06-23 14:06:42 -0700 (Mon, 23 Jun 2008) | 4 lines
 Changed paths:
    M /trunk/epan/crypt/airpdcap.c
 
 Rename a variable to avoid collisions with the old V7 index() function,
 still declared by <string.h> on some platforms (at least the way we
 compile, with all sorts of non-ANSI C/non-POSIX stuff added).
 
 ------------------------------------------------------------------------
 r25581 | guy | 2008-06-24 11:10:57 -0700 (Tue, 24 Jun 2008) | 2 lines
 Changed paths:
    M /trunk/epan/crypt/airpdcap.c
 
 Fix another variable named "index".
 
 ------------------------------------------------------------------------
 r25879 | gerald | 2008-07-30 15:32:21 -0700 (Wed, 30 Jul 2008) | 42 lines
 Changed paths:
    M /trunk/AUTHORS
    M /trunk/epan/crypt/airpdcap.c
    M /trunk/epan/crypt/airpdcap_debug.h
    M /trunk/epan/crypt/airpdcap_int.h
    M /trunk/epan/crypt/airpdcap_rijndael.c
    M /trunk/epan/crypt/airpdcap_rijndael.h
    M /trunk/epan/crypt/airpdcap_tkip.c
 
 Add WPA group key decryption from Brian Stormont, via bug 1420:
 
 Although this patch successfully recognizes group keys and decrypts packets
 properly using the group key, there is a limitation.  If an AP is using key
 rotation, clicking on individual packets in a trace may not properly decrypt a
 packet encrypted with a group key.  This is because the current structure used
 in Wireshark only supports one active unicast and one active group key.  If a
 new key has been seen, but you are looking at a packet encrypted with an older
 key, it will not decrypt.  The summary lines, however, do show the packets
 properly decrypted.
 
 I've written up a much longer and more detailed explanation in a comment in the
 code, along with a proposed idea for a solution, plus a clunky work-around in
 the GUI when using the current code.
 
 I also suspect there might still be a problem with decrypting TKIP groups keys
 that are sent using WPA2 authentication.  In the most common operation, if you
 are using WPA2, you'll also be using AES keys. It's not a common AP
 configuration to use WPA2 with TKIP. In fact, most APs don't seem to support
 it.  Since it is an uncommon setup, I haven't put aside the time to test this
 patch against such an AP.   I do have access to an AP that supports this, so
 when I have the time I'll test it and if needed, will submit another patch to
 handle that odd-ball condition.
 
 From me:
 
 Remove the decrypt element of s_rijndael_ctx (which was unused, as indicated
 in the comments).
 Preserve the GPL licensing text in several files (which the patch shouldn't
 have removed).
 Remove changes that added whitespace.
 Convert C++-style comments to C-style.
 Update to include recent SVN changes (e.g. renaming variables named "index").
 Remove extraneous printf's.
 Define DEBUG_DUMP in airpdcap_debug.h.
 Comment out some instances of DEBUG_DUMP.
 Change malloc/free to g_malloc/g_free.
 Use g_memdup instead of allocating and copying.
 Use gint16 instead of INT16 in airpdcap_rijndael.c.
 Add Brian to AUTHORS.
 
 ------------------------------------------------------------------------
 r25890 | etxrab | 2008-08-01 04:20:50 -0700 (Fri, 01 Aug 2008) | 3 lines
 Changed paths:
    M /trunk/asn1/ldap/packet-ldap-template.c
    M /trunk/asn1/ldap/packet-ldap-template.h
    M /trunk/epan/dissectors/packet-ldap.c
    M /trunk/epan/dissectors/packet-ldap.h
 
 From   Yaniv Kaul:
 ( I edited the template files)
 Failure to dissect long SASL wrapped LDAP response.
 ------------------------------------------------------------------------
 r25923 | lego | 2008-08-04 16:15:54 -0700 (Mon, 04 Aug 2008) | 5 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-k12.c
 
 Fix an ep memory corruption due to passing ep blocks into a se allocated structure.
 
 far away from UAT...
 
 ------------------------------------------------------------------------
 r25924 | lego | 2008-08-04 16:25:07 -0700 (Mon, 04 Aug 2008) | 3 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-k12.c
 
 if it's se allocated it needs to be filled only once.
 
 ------------------------------------------------------------------------
 r25956 | kukosa | 2008-08-08 04:37:29 -0700 (Fri, 08 Aug 2008) | 1 line
 Changed paths:
    M /trunk/asn1/Makefile.am
 
 Include asn1/Makefile.inc.nmake and asn1/Makefile.preinc.nmake into the distribution package
 ------------------------------------------------------------------------
 r25961 | jake | 2008-08-08 12:57:50 -0700 (Fri, 08 Aug 2008) | 2 lines
 Changed paths:
    M /trunk/gtk/rtp_analysis.c
 
 Fix for bug 2780:
 Correct reverse direction payload save.
 ------------------------------------------------------------------------
 r25964 | jake | 2008-08-08 14:22:33 -0700 (Fri, 08 Aug 2008) | 2 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-rtcp.c
 
 Fix for bug 2778:
 Bye string is "null padded", not "null terminated". Change code to test for that fact.
 ------------------------------------------------------------------------
 r25600 | guy | 2008-06-25 02:10:50 -0700 (Wed, 25 Jun 2008) | 7 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-ncp2222.inc
 
 Clean up indentation.
 
 Make build_expert_data() take the size of "buffer" as an argument, and
 use that when doing g_snprintf() into the buffer, to ensure we don't
 overflow the buffer.  Also, don't just assign to "buffer", as that
 doesn't put anything *in* the buffer.
 
 ------------------------------------------------------------------------
 r25682 | wmeier | 2008-07-08 18:30:30 -0700 (Tue, 08 Jul 2008) | 2 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-btrfcomm.c
    M /trunk/epan/dissectors/packet-ncp2222.inc
 
 Fix some mis-spellings
 
 ------------------------------------------------------------------------
 r25683 | wmeier | 2008-07-08 19:30:39 -0700 (Tue, 08 Jul 2008) | 2 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-ncp2222.inc
 
 Fix some spacing .....
 
 ------------------------------------------------------------------------
 r25807 | morriss | 2008-07-23 13:35:28 -0700 (Wed, 23 Jul 2008) | 1 line
 Changed paths:
    M /trunk/epan/dissectors/packet-ncp2222.inc
 
 Don't use proto_tree_add_uint_hidden() any more: it's deprecated.
 ------------------------------------------------------------------------
 r25892 | etxrab | 2008-08-01 04:56:57 -0700 (Fri, 01 Aug 2008) | 2 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-ncp2222.inc
 
 From Bill Meier:
 segmentation fault loading trace containing NCP packets.
 ------------------------------------------------------------------------
 r25911 | wmeier | 2008-08-03 19:27:20 -0700 (Sun, 03 Aug 2008) | 2 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-ncp-int.h
    M /trunk/epan/dissectors/packet-ncp2222.inc
 
 Adjust various indentation/spacing; Do some minor reformatting
 
 ------------------------------------------------------------------------
 r25913 | wmeier | 2008-08-03 19:56:47 -0700 (Sun, 03 Aug 2008) | 4 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-ncp2222.inc
 
 Fix 2 bugs:
 - Misplaced } resulted in incorrect program flow in switch statement;
 - Invalid input caused "Dissector bug: infinite loop";
 
 ------------------------------------------------------------------------
 r25914 | wmeier | 2008-08-03 20:46:49 -0700 (Sun, 03 Aug 2008) | 2 lines
 Changed paths:
    M /trunk/epan/dissectors/packet-ncp2222.inc
 
 Print various uints with %u ...
 
 ------------------------------------------------------------------------
 r26012 | gmorris | 2008-08-14 04:40:12 -0700 (Thu, 14 Aug 2008) | 4 lines
 Changed paths:
    M /trunk/epan/dissectors/ncp2222.py
    M /trunk/epan/dissectors/packet-ncp2222.inc
 
 Fix for retransmission of fragmented NDS reply packets.
 Fix for crash in expert file information.
 Fix for malformed NDS iteration packets.
 Fix indention on NDS read attribute definition verb.
 ------------------------------------------------------------------------

Directory: /trunk-1.0/asn1/
  Changes    Path           Action
  +3 -1      Makefile.am    Modified

Directory: /trunk-1.0/epan/crypt/
  Changes    Path                   Action
  +433 -26   airpdcap.c             Modified
  +4 -0      airpdcap_debug.h       Modified
  +2 -0      airpdcap_int.h         Modified
  +313 -1    airpdcap_rijndael.c    Modified
  +3 -1      airpdcap_rijndael.h    Modified
  +8 -2      airpdcap_tkip.c        Modified

Directory: /trunk-1.0/epan/dissectors/
  Changes    Path                  Action
  +1 -1      ncp2222.py            Modified
  +4 -4      packet-btrfcomm.c     Modified
  +11 -14    packet-k12.c          Modified
  +7 -6      packet-ldap.c         Modified


(11 files not shown)