Wireshark-bugs: [Wireshark-bugs] [Bug 12882] TCP packets sometimes are incorrectly parsed as TDS
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 07 Dec 2016 01:22:24 +0000

Comment # 8 on bug 12882 from 
(In reply to Gerrit Code Review from comment #7)
> Change 19125 had a related patch set uploaded by Michael Mann:
> [TDS] Convert to using tcp_dissect_pdus.
> 
> https://code.wireshark.org/review/19125

As the commit message states, this was an excuse to get rid of
conversation_set_dissector that IMO was the problem here.  I think the
heuristic was a bit too far reaching in trying to find a TDS packet.  Most TCP
dissectors that have a heuristic function just do their checks and then call
the dissection function (without conversation_set_dissector), so I made the TDS
dissector match that.  Preferences or Decode As should be good enough like it
is with most dissectors.

You are receiving this mail because:
  • You are watching all bug changes.