Wireshark-bugs: [Wireshark-bugs] [Bug 13044] Buildbot crash output: fuzz-2016-10-25-19751.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 06 Dec 2016 05:44:03 +0000

Comment # 19 on bug 13044 from 
The most recent complaint is with my changes, and the line it's complaining
about is the one that tests cops_call->solicited:

                else if (cops_call->op_code == COPS_MSG_KA) {   
                    if (!(cops_call->solicited)) {
                        if (op_code == COPS_MSG_KA) {
                            if (is_solicited) {
                                cops_call->rsp_num = pinfo->num;
                                break;
                            }
                        }
                    }
                }

so valgrind thinks cops_call->solicited is uninitialized.

The only place where we allocate a cops_call_t is

        if (!pinfo->fd->flags.visited) {
            cops_call = wmem_new(wmem_file_scope(), cops_call_t);
            cops_call->op_code = op_code;
            cops_call->solicited = is_solicited;
            cops_call->req_num = pinfo->num;
            cops_call->rsp_num = 0;
            cops_call->req_time = pinfo->abs_ts;
            g_ptr_array_add(pdus_array, cops_call);
        }

so either

    1) is_solicited isn't initialized

or

    2) when we index into an array of cops_call_t's, we're fetching garbage.

Or 3) valgrind is mistaken....

You are receiving this mail because:
  • You are watching all bug changes.