Wireshark-bugs: [Wireshark-bugs] [Bug 13161] ICMP dissector fails to properly detect timestamps
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 22 Nov 2016 18:02:52 +0000

Comment # 2 on bug 13161 from 
I only looked at frame 2215 and the problem appears to be that the frame time
is 14:58:03.000011000 while the ICMP data time is 14.58:02.999966000.

The code seems to be making the assumption that the ICMP data time will always
be greater than or equal to the frame time, but not earlier, but that is not
the case for this frame, so the heuristics fail.

It would seem that this problem would be resolved if the absolute value of the
time difference was computed instead.

Ref:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=epan/dissectors/packet-icmp.c;h=c2ee26491d0109b5729160864ae395000e3fcbce;hb=HEAD#l1512

You are receiving this mail because:
  • You are watching all bug changes.