Wireshark-bugs: [Wireshark-bugs] [Bug 12855] Follow TCP Stream shows duplicate stream data
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 19 Oct 2016 03:27:50 +0000

changed bug 12855


What Removed Added
Status CONFIRMED IN_PROGRESS

Comment # 18 on bug 12855 from 
(In reply to Michael Mann from comment #17)
> (In reply to Pascal Quantin from comment #16)
> > My patch being far from complete, so my vote is for a revert of the code to
> > previous implementation (for now).
> 
> I just haven't had the time to get to it, but my idea was to turn the
> (original) reassemble_tcp logic into a tap (with tap handling at the UI
> layer).  I have not found a way to handle out of order packets (i.e. Peter's
> samples) with the current tap setup.
> If we're going to revert, I'd like to try to limit it to just TCP, but one
> issue is that the refactoring simplified the code so that TCP/UDP/SCTP are
> all one code path.  I also think the new functionality took at least 2
> commits.

Having some success "refactoring" reassemble_tcp and limiting changes to just
TCP dissector (with maybe some small growth in follow structures).  GUI doesn't
appear to need changing.  I'll post a patch when I have something more concrete
(it's getting a bit late here).

You are receiving this mail because:
  • You are watching all bug changes.