Wireshark-bugs: [Wireshark-bugs] [Bug 12788] "DTMF RTP EVENT" decoding not fully working in Wire
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 01 Sep 2016 22:26:40 +0000

Comment # 3 on bug 12788 from 
in packet-sdp.c:setup_sdp_transport() there's a note stating:

        /* Increase the count of media channels, but don't walk off the end of
the arrays. */
        /* XXX: I don't know why this was done here - I'm keeping it here in
case
         * removing it causes problems, but it's wrong.
transport_info->media_count
         * is already incremented in the while() loop above. Incrementing it
         * again here will cause bugs. 

And indeed seems. Removing these lines

        if (transport_info->media_count < (SDP_MAX_RTP_CHANNELS-1))
            transport_info->media_count++;

seems to solve this problem. 
There's still crap in transport_info contents though, so there may be more.
And the note author could be right that this change causes other problems to
appear.
Needs further investigation.

You are receiving this mail because:
  • You are watching all bug changes.