Wireshark-bugs: [Wireshark-bugs] [Bug 12687] SocketCAN dissector does not support CAN FD
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 22 Aug 2016 19:40:21 +0000

Comment # 40 on bug 12687 from 
(In reply to Oliver Hartkopp from comment #39)
> (In reply to Guy Harris from comment #35)

Back on air :-)

First the pcap-canusb-linux.c can be removed from libpcap as the unit never
reached production maturity!

https://github.com/axos88/libpcap/commit/f3edbb599b8cbcc7e4560000dcba8e992dc11a31#commitcomment-18716617

Sad for Akos but good for us :-\

Second: I complied the latest libpcap with Guys changes and the latest
Wireshark together with the ninth patch set from Michael
https://code.wireshark.org/review/#/c/16787/

Because of my missing patch to piggyback CAN FD traffic into the existing
pcap-can-linux.c these latest versions fall back to only handle CAN frames.

So what would be the best steps to continue?

1. Remove pcap-canusb-linux.c
2. Remove pcap-can-linux.c

3. Let pcap-linux.c handle and provide

    DLT_CAN_SOCKETCAN_BIGENDIAN  (for ETH_P_CAN)
    DLT_CAN_SOCKETCAN_HOSTENDIAN (for ETH_P_CAN)

    DLT_CANFD_SOCKETCAN_BIGENDIAN  (for ETH_P_CANFD) NEW! (needed??)
    DLT_CANFD_SOCKETCAN_HOSTENDIAN (for ETH_P_CANFD) NEW!

4. Update Wireshark to support these new DLTs

Good idea / bad idea ??

BR Oliver

You are receiving this mail because:
  • You are watching all bug changes.