Wireshark-bugs: [Wireshark-bugs] [Bug 12687] SocketCAN dissector does not support CAN FD
Comment # 28
on bug 12687
from Guy Harris
(In reply to Oliver Hartkopp from comment #27)
> sure I could have sent a pull request. But I was not really sure if
> extending pcap-can-linux.c in my suggested way is the 'right way' to go.
> That's why I first wanted to discuss both changes here.
This is the wrong place to discuss libpcap changes; libpcap is not part of
Wireshark and is not intended only to be used by Wireshark.
The best ways to discuss a change to libpcap are either to make a pull request
and do the discussion there, to add a non-pull-request issue for libpcap on
GitHub and do the discussion there, or to post a message to
tcpdump-workers@lists.tcpdump.org.
The advantage of the first of those is that the changes are visible from the
pull request and line comments can be made; it's the equivalent of a Gerrit
discussion for Wireshark changes.
If you want to discuss the change at a layer above the actual code layer,
either a non-pull-request issue or a mail message to tcpdump-workers would be
appropriate (just as, for Wireshark, a bug or mail message to wireshark-dev
would be appropriate).
You are receiving this mail because:
- You are watching all bug changes.
