Wireshark-bugs: [Wireshark-bugs] [Bug 10681] UTF-8 replacement characters in FT_STRINGs are esca
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 15 Apr 2016 01:34:10 +0000

Comment # 10 on bug 10681 from 
(In reply to Jeff Morriss from comment #9)
> (In reply to Guy Harris from comment #8)
> > I seem to remember some discussion of this and some concern that doing the
> > validation would slow down dissection significantly.  If so, perhaps what
> > needs to be done is to have the value of an FT_STRING field be a combination
> > of an ENC_ value and a raw blob of bytes copied directly from the packet,
> > with the blob converted to valid UTF-8 when necessary - with that
> > conversion, for ENC_UTF_8, getting rid of invalid UTF-8 sequences.
> 
> When (at what point) would it be necessary?

Or is it necessary at all?

If I change the string_enc function to use ENC_UTF_8 and take out the assertion
the Qt UI displays the (partially garbage) URI without a complaint.

The Gtk+ UI complains mildly:

(lt-wireshark-gtk:5865): Pango-WARNING **: Invalid UTF-8 string passed to
pango_layout_set_text()


but presumably at this point we don't really care?

You are receiving this mail because:
  • You are watching all bug changes.