Wireshark-bugs: [Wireshark-bugs] [Bug 12309] New: QT Multicast Stream Dialog error in input fiel
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 30 Mar 2016 12:54:00 +0000
Bug ID 12309
Summary QT Multicast Stream Dialog error in input field Burst alarm threshold and Buffer alarm
Product Wireshark
Version 2.0.2
Hardware x86
OS Windows 7
Status UNCONFIRMED
Severity Normal
Priority Low
Component Qt UI
Assignee bugzilla-admin@wireshark.org
Reporter benoit.grange@gmail.com 

Build Information:
Version 2.0.2 (v2.0.2-0-ga16e22e from master-2.0)

Copyright 1998-2016 Gerald Combs <gerald@wireshark.org> and contributors.
License GPLv2+: GNU GPL version 2 or later
<http://www.gnu.org/licenses/old-licenses/gpl-2.0.html>
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.3.2, with WinPcap (4_1_3), with libz 1.2.8, with
GLib 2.42.0, with SMI 0.4.8, with c-ares 1.9.1, with Lua 5.2, with GnuTLS
3.2.15, with Gcrypt 1.6.2, with MIT Kerberos, with GeoIP, with QtMultimedia,
with AirPcap.

Running on 64-bit Windows 7 Service Pack 1, build 7601, with locale C, with
WinPcap version 4.1.3 (packet.dll version 4.1.0.2980), based on libpcap version
1.0 branch 1_0_rel0b (20091008), with GnuTLS 3.2.15, with Gcrypt 1.6.2, without
AirPcap.
Intel(R) Core(TM) i5-5300U CPU @ 2.30GHz (with SSE4.2), with 8080MB of physical
memory.


Built using Microsoft Visual C++ 12.0 build 40629

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
I had doubts regarding the multicast statistics and indeed there is a coding
error while handling user input in the "buffer alarm" input field of the
dialog.

Steps to reproduce:

Open a capture
Open the multicast statistics dialog
In the input fields at the bottom type the following values (one in each
field): 1, 2, 3, 4, 5. Validate the input with enter.
Close the dialog
Open the multicast statistics dialog again
Look at the fields in the dialog and see: 1, 3, 10000, 4, 5 which is wrong, one
parameter has been transferred to the wrong field.

I had a look at the source code and see in
/ui/qt/multicast_statistics_dialog.cpp in function
MulticastStatisticsDialog::updateMulticastParameters() 

 401     param = burst_alarm_threshold_le_->text().toInt(&ok);
 402     if (ok) {
 403         mcast_stream_trigger = param;
 404     }
 405 
 406     param = buffer_alarm_threshold_le_->text().toInt(&ok);
 407     if (ok && param > 0) {
 408         mcast_stream_trigger = param;
 409     }

And line 408 is wrong, it was a copy and past from line 403, it should read

mcast_stream_bufferalarm = param

I wish I could push a patch by myself but it is a big too long for me to setup
a build environement for this one liner change ! Can someone do it ?

You are receiving this mail because:
  • You are watching all bug changes.